fix(nonce-reuse): verify recovered keys against pubkey and handle mixed s-normalization#18
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
d*G == pubkey) instead of returning unverified resultsProblem
The nonce-reuse attack previously returned the first mathematically valid private key without verifying it against the known public key. This caused two issues:
swas BIP62-canonicalized (low-s) and the other wasn't, the standard formulak = (z₁-z₂)/(s₁-s₂)yields the wrong nonce, and recovery silently failsSolution
When pubkey is present:
d*Gand compare against the provided pubkey (compressed and uncompressed)s₂and-s₂, verifying each candidate — only return the key that matchesbiased_nonce::verify_candidateandpolynonce::verify_keyWhen pubkey is absent:
Tests
test_nonce_reuse_recovery_with_pubkey_verification— EC-consistent signatures with knownd, verifies correct key recoverytest_nonce_reuse_recovery_negated_s_with_pubkey— Same setup but withs₂negated, proves s-polarity handling works